-
Notifications
You must be signed in to change notification settings - Fork 186
except_regex argument for todo_comment_linter() to skip valid TODO comments #2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable it for us? (Follow up is fine)
Hmm that blew up. Let me know if anything here should be split into its own PR. |
Seems manageable to me. The comment fixes will probably be easy to review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 126 126
Lines 5671 5676 +5
=======================================
+ Hits 5588 5593 +5
Misses 83 83 ☔ View full report in Codecov by Sentry. |
LGTM. Ping when you want to merge this (to avoid tons of "Update branch" merges with the current set of PRs |
g2g, btw, as long as there's no conflicts merge commits don't invalidate reviews. a bit hard to forecast which will cause conflicts OTOH. |
Based against #2438.
Closes #2047