-
Notifications
You must be signed in to change notification settings - Fork 186
Support pattern-based exclusion in return_linter() #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 126 126
Lines 5659 5670 +11
=======================================
+ Hits 5576 5587 +11
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Very nice feature - makes the linter much more attractive for larger code bases. |
Closes #2335.
Implementation is maybe not ideal since it requires running the
//FUNCTION | //OP-LAMBDA
XPath twice -- once to find the names of assigned functions, a second time to check for lints.The workaround I could think of was to (1) find all
//FUNCTION | //OP-LAMBDA
nodes (2) partition into assigned vs. unassigned (3) trimexcept|except_regex
from the assigned group (4)combine_nodesets()
(4) check for lints. But IINM this would require refactoring a lot of other code as well, I'm not sure it's worth it --//FUNCTION | //OP-LAMBDA
should be relatively fast.