Remove false negatives with seq() in seq_linter()

R/seq_linter.R

@@ -14,19 +14,22 @@
 #' @export
 seq_linter <- function() {
   bad_funcs <- c("length", "n", "nrow", "ncol", "NROW", "NCOL", "dim")
-  bad_func_xpath <- glue::glue(
+  bad_func_xpath_with_seq <- glue::glue(
+    "expr[1][SYMBOL_FUNCTION_CALL[text() = 'seq']]/following::expr[1]/expr[SYMBOL_FUNCTION_CALL[{xp_text_in_table(bad_funcs)}]]"
+  )
+  bad_func_xpath_without_seq <- glue::glue(
     "expr[expr[(expr|self::*)[SYMBOL_FUNCTION_CALL[ {xp_text_in_table(bad_funcs)} ]]]]"
   )
 
   # `.N` from {data.table} is special since it's not a function but a symbol
   xpath <- glue::glue("//expr[
     (
-      expr[SYMBOL_FUNCTION_CALL[text() = 'seq']]
-      and {bad_func_xpath}
+      { bad_func_xpath_with_seq }
+      and count(expr) = 2
     ) or (
-      expr[NUM_CONST[text() =  '1' or text() =  '1L']]
+      expr[NUM_CONST[text() = '1' or text() = '1L']]
       and OP-COLON
-      and ( {bad_func_xpath} or expr[SYMBOL = '.N'] )
+      and ( {bad_func_xpath_without_seq} or expr[SYMBOL = '.N'] )
     )
   ]")