skip evaluation that hangs on bad input #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Jul 10, 2022
MichaelChirico
commented
Jul 10, 2022
AshesITR
reviewed
Jul 11, 2022
AshesITR
reviewed
Jul 24, 2022
R/tree-utils.R
Outdated
| tl_parent[i_not_assigned] <- pc$parent[match(tl_parent[i_not_assigned], pc$id)] | ||
| i_not_assigned <- which(!tl_parent %in% tl_ids) | ||
| if (length(i_not_assigned) >= prev_length) { | ||
| stop("Logical error: unassigned set did not shrink. Check file syntax and please report as a bug.") |
There was a problem hiding this comment.
Add GitHub issue link? As-is the error message might not be clearly linked to lintr in production.
There was a problem hiding this comment.
Just added 'lintr' -- should be slightly more stable than referencing the GH link (GH site structure changes, or "turns evil" & we change hosts, etc)
AshesITR
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1443
Not totally happy we've solved the problem with a high level of generality, but it does close the issue at hand.