Skip to content

set error linter name to "error" #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2022
Merged

set error linter name to "error" #1408

merged 7 commits into from
Jun 17, 2022

Conversation

AshesITR
Copy link
Collaborator

fixes #1405

@AshesITR
Copy link
Collaborator Author

As it turns out, the unparseable files actually caused lint() to error due to line_length_linter() running nchar() on file_lines.
I opted to simply refuse to lint files with completely invalid content (it's not parseable anyway).

@MichaelChirico MichaelChirico merged commit c4c10ec into main Jun 17, 2022
@MichaelChirico MichaelChirico deleted the fix/1405-error-linter-name branch June 17, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github comment bot failed to find the linter name, prints NA
2 participants
@AshesITR @MichaelChirico