Use partial matching for linter names in exclusion directives #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/testthat/dummy_projects/project/partially_matched_exclusions.R
Outdated
Show resolved
Hide resolved
| test_that("partial matching works for exclusions but warns if no linter found", { | ||
| read_settings(NULL) | ||
|
|
||
| expect_warning( |
There was a problem hiding this comment.
is this really the way to do multiple warning tests in testthat? oh boy 😂
the withCallingHandlers approach is not particularly nicer... maybe we need a helper. i've definitely written expect_warnings() before.
otoh, it seems like an intentional design decision that testthat has limited matching exactly one warning at a time:
There was a problem hiding this comment.
Yeah, pretty bulky. I think they should allow to somehow vectorize on regexp so that multiple warnings each matching some regex are expected.
There was a problem hiding this comment.
Filed r-lib/testthat#1625 as a suggestion
|
LGTM after small fix to reduce redundancy |
MichaelChirico
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #872
# nolints to the short-hand notationusing_lintrvignette