Skip to content

Remove context() from tests #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AshesITR opened this issue Dec 4, 2020 · 3 comments
Closed

Remove context() from tests #665

AshesITR opened this issue Dec 4, 2020 · 3 comments
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Milestone
3.0.0

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 4, 2020

See https://www.tidyverse.org/blog/2020/10/testthat-3-0-0/ -- it's already kind of vestigial, and will be deprecated from testthat 3.0.0

Originally posted by @MichaelChirico in #648 (comment)

context() calls should be removed from all test files.

Some test files currently define multiple contexts.

  • test-exclusions.R (3 contexts) should be split into separate files
  • test-cache.R (tons of contexts) should go without contexts, maybe update test_that() descriptions.

The vignette creating_linters.Rmd recommends using context(). That should also be removed.
@AshesITR
Copy link
Collaborator Author

AshesITR commented Dec 4, 2020

#660 splits test-exclusions.R.

@AshesITR AshesITR mentioned this issue Dec 6, 2020
Merged
@AshesITR
Copy link
Collaborator Author

AshesITR commented Dec 6, 2020

The rest is handled in #696

@russHyde russHyde added the internals Issues related to inner workings of lintr, i.e., not user-visible label Dec 9, 2020
@MichaelChirico MichaelChirico added this to the 3.0.0 milestone Jan 31, 2021
@MichaelChirico
Copy link
Collaborator

Closes in #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@AshesITR @MichaelChirico @russHyde