add coverage test for methods.R #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Dec 1, 2020
| @@ -1,4 +1,3 @@ | |||
| context("rstudio_source_markers") | |||
There was a problem hiding this comment.
Why has the test context been removed?
There was a problem hiding this comment.
See https://www.tidyverse.org/blog/2020/10/testthat-3-0-0/ -- it's already kind of vestigial, and will be deprecated from testthat 3.0.0
There was a problem hiding this comment.
If you think it's better to keep the removal of context() to a separate PR, lmk. just stripped it while I'm in here.
There was a problem hiding this comment.
Okay, thanks for the link - missed that.
I think it's okay to remove it gradually.
AshesITR
previously approved these changes
Dec 1, 2020
MichaelChirico
changed the title
AshesITR
requested changes
Dec 4, 2020
AshesITR
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything uncovered in methods.R is covered by #630