Skip to content

Make sure lintr finds .lintr files when called from plugins. #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jimhester opened this issue Dec 11, 2015 · 1 comment · Fixed by #503
Closed

Make sure lintr finds .lintr files when called from plugins. #123

jimhester opened this issue Dec 11, 2015 · 1 comment · Fixed by #503
Labels
bug an unexpected problem or unintended behavior
Milestone
3.0.0

Comments

@jimhester
Copy link
Member

The plugins usually call lint() with a tempfile rather than the acutal filename, we need to change the lint() API to take a optional filepath as well, which can be used to find the project configuration file.
@jimhester jimhester mentioned this issue Dec 11, 2015
Closed
@jimhester jimhester added the bug an unexpected problem or unintended behavior label Dec 30, 2015
@jimhester jimhester added this to the Jan. 4 milestone Dec 30, 2015
@jabranham jabranham mentioned this issue May 23, 2018
Closed
jabranham added a commit to jabranham/lintr that referenced this issue Jul 24, 2018
@jabranham
Allow users to set lintr.linter_file
c11fdc1 
This lets users specify the location of the linter file with
options(lintr.linter_file) before calling lintr::lint(). This should
be useful to allow the various plugins to specify the path to the
.lintr file

Related to r-lib#123 and r-lib#335
@jabranham jabranham mentioned this issue Jul 24, 2018
Merged
jabranham added a commit to jabranham/lintr that referenced this issue Jul 25, 2018
@jabranham
Allow users to set lintr.linter_file
db4b348 
This lets users specify the location of the linter file with
options(lintr.linter_file) before calling lintr::lint(). This should
be useful to allow the various plugins to specify the path to the
.lintr file

Related to r-lib#123 and r-lib#335
jimhester pushed a commit that referenced this issue Jul 25, 2018
@jabranham @jimhester
Allow users to set lintr.linter_file (#338)
baddc5b 
This lets users specify the location of the linter file with
options(lintr.linter_file) before calling lintr::lint(). This should
be useful to allow the various plugins to specify the path to the
.lintr file

Related to #123 and #335
@jimhester jimhester mentioned this issue Sep 26, 2019
Closed
@StefanBRas StefanBRas mentioned this issue Mar 5, 2020
Closed
@AshesITR AshesITR linked a pull request Feb 8, 2021 that will close this issue
Add text argument to lint #503
Merged
2 tasks
@AshesITR AshesITR modified the milestones: Jan. 4, 3.0.0 Feb 8, 2021
@AshesITR
Copy link
Collaborator

AshesITR commented Feb 8, 2021

#503 implements this via the file argument, whose contents will be ignored when text is also present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Add text argument to lint r-lib/lintr
2 participants
@jimhester @AshesITR