Skip to content

Cyclomatic complexity lints in lintr #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
13 of 14 tasks
AshesITR opened this issue May 22, 2022 · 0 comments · Fixed by #1236
Closed
13 of 14 tasks

Cyclomatic complexity lints in lintr #1186

AshesITR opened this issue May 22, 2022 · 0 comments · Fixed by #1236
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible

Comments

@AshesITR
Copy link
Collaborator

AshesITR commented May 22, 2022 •
edited
Loading

After fixing all implicit integer lints, we can almost use .lintr_new, except for cyclomatic complexity:

  • lint: 40 -> 29
  • lint_parse_error: 24
  • commas_linter: 23
  • object_usage_linter: 21
  • sprintf_linter: 19
  • normalize_exclusions: 18
  • fix_eq_assigns: 18
  • available_linters: 18
  • namespace_linter: 18
  • closed_curly_linter: 17
  • split_path: 17
  • fix_tab_indentations: 16
  • lint_dir: 16
  • open_curly_linter: 16
@AshesITR AshesITR added the internals Issues related to inner workings of lintr, i.e., not user-visible label May 22, 2022
@AshesITR AshesITR changed the title Cyclomatic complexity Cyclomatic complexity lints in lintr May 22, 2022
This was referenced May 23, 2022
Closed
Merged
Merged
Merged
This was referenced May 24, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced May 25, 2022
Closed
Merged
Merged
@AshesITR AshesITR mentioned this issue May 25, 2022
Merged
This was referenced May 25, 2022
Merged
Merged
@AshesITR AshesITR mentioned this issue May 25, 2022
Merged
This was referenced May 26, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce cyclocomp of lint() to <= 15 r-lib/lintr
1 participant
@AshesITR