Skip to content

simplify open_curly_linter using xpath #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2022
Merged

simplify open_curly_linter using xpath #1221

merged 2 commits into from
May 25, 2022

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented May 25, 2022 •
edited
Loading

Closes #1220; part of #1186

AshesITR
AshesITR previously approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can't find the test case "a <- function() { \n}" (only "a <- function() {\n}").
Was that intentional?

@MichaelChirico
Copy link
Collaborator Author

LGTM, but I can't find the test case "a <- function() { \n}" (only "a <- function() {\n}"). Was that intentional?

I guess we should keep that in, just changing it to a true negative

@AshesITR AshesITR merged commit 2040068 into main May 25, 2022
@AshesITR AshesITR deleted the cyclo-open-curly branch May 25, 2022 06:17
@AshesITR AshesITR mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop lint for trailing whitespace after { ?
2 participants
@MichaelChirico @AshesITR