-
Notifications
You must be signed in to change notification settings - Fork 186
docs: package to be linted should be installed #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not sure if useful info, but using The problem is lintr only lints one file at a time so it can't see function definitions from around the codebase during linting. A similar issue will happen when linting regular files that I'm actually confused why simply installing the linted package fixed the issue at all. |
* add link check * add installation * update linters based on custom style guide * use .lintr as default settings * fix issue * fix update error * workaround for object_usage_lintr see r-lib/lintr#1137 * fix comma
I'm thinking the way to document this is with tags -- it only really applies to Lines 93 to 101 in fa914d0
And maybe mention this class of linters in the README/intro vignette. |
attemp to fix: r-lib/lintr#1137
Linting a package that is not installed may generate false positives for (at least)
object_usage_linter
, see e.g. r-lib/actions#557Re 2: I took
lintr/README.md
Lines 217 to 218 in fff7808
lintr/README.md
Line 192 in fff7808
section, because it is also valid for GHA.
But the "package should be installed" applies locally as well, so maybe it should be in the
lint_package()
docs? Maybe something likeThe text was updated successfully, but these errors were encountered: