Upgrade tantivy 0.24. Fixes #470 #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Ok tests are passing. I want to go over the changes again to check for efficiency. |
wallies
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the tantivy dependency to version 0.24.0 and updates test expectations and error messages to match the new API behavior. Key changes include:
- Modifications to test cases to account for new query representations and error messages.
- Updates in snippet and query modules to use revised module paths and API calls.
- Adjustments in document handling to switch from using BTreeMap to a Vec of key/value pairs.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_escapes.py | Updated test behavior to expect no error with escape characters. |
| tests/tantivy_test.py | Modified expected query representations and error messages. |
| src/snippet.rs | Updated module paths for snippet generator usage. |
| src/query.rs | Revised range query API to conform to updated tantivy usage. |
| src/document.rs | Changed JSON conversion from a BTreeMap to a Vec of tuples. |
| Cargo.toml | Upgraded tantivy dependency to version 0.24.0. |
| # from tantivy versions prior to 0.24.0 in which the following would | ||
| # raise a `ValueError`. | ||
| q = index.parse_query(r'sea\"', ["title", "body"]) | ||
| print(q) |
There was a problem hiding this comment.
The print statement appears to be a leftover debug output. It is recommended to remove it unless it serves a specific purpose in the test.
Suggested change
| print(q) |
Copilot uses AI. Check for mistakes.
|
Really good to get #401 in somehow after this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a couple failing tests to work through.