add available device to regression tests #3335 #3394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BanzaiTokyo
changed the title
…al_bias.py, test_geometric_mean_absolute_error.py
BanzaiTokyo
force-pushed
the
regression_tests_add_available_device
branch
from
ae57e4b to
f99b643
Compare
BanzaiTokyo
force-pushed
the
regression_tests_add_available_device
branch
from
1b9ee36 to
3dbbe1e
Compare
BanzaiTokyo
force-pushed
the
regression_tests_add_available_device
branch
2 times, most recently
from
9b1e5fe to
b87df91
Compare
BanzaiTokyo
force-pushed
the
regression_tests_add_available_device
branch
from
b87df91 to
6f0599d
Compare
vfdev-5
reviewed
Apr 25, 2025
BanzaiTokyo
changed the title
vfdev-5
reviewed
Apr 28, 2025
vfdev-5
reviewed
Apr 28, 2025
vfdev-5
reviewed
Apr 28, 2025
|
@vfdev-5 I believe I have addressed your comments, please, review again to make sure everything is ok |
vfdev-5
reviewed
May 2, 2025
There was a problem hiding this comment.
Let's split this PR into multiple ones and make them merge once you are done porting 1 or 2 metrics. We want to do the following:
- add available_device
- use tensor API instead of numpy for data creation
- rewrite test_integration tests using pytest parametrize instead of nested _test methods
Comment on lines
+122
to
+128
| denom = y_pred_var * y_var | ||
| denom = torch.clamp(denom, min=self.eps) | ||
| denom = torch.sqrt(denom) | ||
| r = cov / denom | ||
|
|
||
| if torch.isnan(r): | ||
| return 0.0 |
There was a problem hiding this comment.
Why this change ? Have you checked with the original implementation?
There was a problem hiding this comment.
just to make sure I ran the tests once again. Without this snippet, on MPS a division by zero produces NaN:
FAILED tests/ignite/metrics/regression/test_pearson_correlation.py::test_degenerated_sample[mps] - assert 0.0 ± 1.0e-12 == nan
comparison failed
Obtained: nan
Expected: 0.0 ± 1.0e-12
tests/ignite/metrics/regression/test_fractional_absolute_error.py
Outdated
Show resolved
Hide resolved
BanzaiTokyo
force-pushed
the
regression_tests_add_available_device
branch
from
09d4913 to
346e0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.