GH-96793: Implement PEP 479 in bytecode. #99006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
markshannon
commented
Nov 2, 2022
| @@ -346,7 +346,7 @@ def make_tracer(): | |||
| return Tracer() | |||
|
|
|||
| def compare_events(self, line_offset, events, expected_events): | |||
| events = [(l - line_offset, e) for (l, e) in events] | |||
| events = [(l - line_offset if l is not None else None, e) for (l, e) in events] | |||
There was a problem hiding this comment.
I introduced for debugging this PR. It is no longer strictly necessary, but it gives nicer output when tests fail.
iritkatriel
reviewed
Nov 2, 2022
|
|
||
| static int | ||
| wrap_in_stopiteration_handler(struct compiler *c) | ||
| { |
There was a problem hiding this comment.
I wonder if this is not wrapping too much, like the instructions that deal with the function's arguments and annotations?
There was a problem hiding this comment.
Annotations are executed in the enclosing scope, as are defaults. So there is no problem there.
MAKE_CELL and RETURN_GENERATOR instructions are inserted in the back-end so happen after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to specialize iteration over generators and send to coroutines we need to remove the pre- and post checks from the C wrappers.
The pre-checks are largely eliminated by the the compiler and specialization.
The post-checks need to be handled in bytecode.
To do that, we wrap the generator body in a
try: ... except StopIteration: ...which converts theStopIterationinto aRuntimeError.I initially did this entirely in bytecode, but it adds a lot of bulk to the bytecode.
The new
STOPITERATION_ERRORinstruction should only be temporary: #99005for gen():, and awaiting coroutines,await coro()#96793