Skip to content

gh-92206: Improve scoping of sqlite3 reset statement helper #92241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

gh-92206: Improve scoping of sqlite3 reset statement helper #92241

merged 2 commits into from
May 3, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 3, 2022 •
edited
Loading

resolves gh-92206

@JelleZijlstra
Copy link
Member

Should remove it from the header too.

@erlend-aasland
Copy link
Contributor Author

(I prefer to use this window of opportunity to rename the function; file local functions do not need long namespace prefixes.)

@erlend-aasland
Copy link
Contributor Author

Should remove it from the header too.

🤦🏻

@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
@JelleZijlstra JelleZijlstra merged commit 4159443 into python:main May 3, 2022
@erlend-aasland erlend-aasland deleted the sqlite-move-reset branch May 3, 2022 17:50
@erlend-aasland erlend-aasland mentioned this pull request May 3, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3: improve scoping of functions in the sqlite3 extension module
3 participants
@erlend-aasland @JelleZijlstra @bedevere-bot