[2.7] bpo-31478: Prevent unwanted behavior in _random.Random.seed() in case the arg has a bad __abs__() method (GH-3596) #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_random.py
Outdated
| expected_value = self.gen.random() | ||
| for seed_arg in [42L, BadInt(42), BadLong(42)]: | ||
| self.gen.seed(seed_arg) | ||
| self.assertEqual(expected_value, self.gen.random()) |
There was a problem hiding this comment.
Use the actual value at left and the expected value at right.
serhiy-storchaka
approved these changes
Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_random.Random.seed()is along/intsubclass, ignore its__abs__()method.test_randomto verify that such__abs__()methods are indeed ignored.https://bugs.python.org/issue31478