bpo-35108: handle exceptions in inspect.getmembers #18330
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes inspect.getmembers robust to classes that raise exceptions
other than AttributeError in properties.
In https://bugs.python.org/issue35108, @tirkarthi suggested using
getattr_static
for these types of properties. It would also suggested thatI wasn't able to construct a test case that raised an exception in
getattr_static
, so I haven't implemented the suggestion that we skip the attribute in this case. Happy to add a test case if anyone is able to provide some guidance.https://bugs.python.org/issue35108