Skip to content

bpo-35108: handle exceptions in inspect.getmembers #18330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TomAugspurger
Copy link

@TomAugspurger TomAugspurger commented Feb 3, 2020

Makes inspect.getmembers robust to classes that raise exceptions
other than AttributeError in properties.

In https://bugs.python.org/issue35108, @tirkarthi suggested using getattr_static for these types of properties. It would also suggested that

there might be still cases where getattr_static triggers an exception too where we need to decide whether to skip the attribute from being listed and if so with a test for the scenario.

I wasn't able to construct a test case that raised an exception in getattr_static, so I haven't implemented the suggestion that we skip the attribute in this case. Happy to add a test case if anyone is able to provide some guidance.

https://bugs.python.org/issue35108

Makes inspect.getmembers robust to classes that raise exceptions
other than AttributeError in properties.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@TomAugspurger

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@TomAugspurger
Copy link
Author

We've worked around this in pandas with pandas-dev/pandas#33628.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants