Skip to content

bpo-1635741: Port _bisect extension module to multiphase initialization(PEP 489) #18049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bpo-1635741: Port _bisect extension module to multiphase initialization(PEP 489) #18049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c3060
Port _bisect extension module to multiphase initialization(PEP 489)
shihai1991 Jan 18, 2020
ac0791f
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-01-18-10-49-17.bpo-1635741.ee-6-z.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Port _bisect extension module to multiphase initialization (:pep:`489`).
9 changes: 6 additions & 3 deletions Modules/_bisectmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,17 @@ having to sort the list after each insertion. For long lists of items with\n\
expensive comparison operations, this can be an improvement over the more\n\
common approach.\n");

static PyModuleDef_Slot _bisect_slots[] = {
{0, NULL}
};

static struct PyModuleDef _bisectmodule = {
PyModuleDef_HEAD_INIT,
"_bisect",
module_doc,
-1,
0,
bisect_methods,
NULL,
_bisect_slots,
NULL,
NULL,
NULL
Expand All @@ -276,5 +279,5 @@ static struct PyModuleDef _bisectmodule = {
PyMODINIT_FUNC
PyInit__bisect(void)
{
return PyModule_Create(&_bisectmodule);
return PyModuleDef_Init(&_bisectmodule);
}