Skip to content

gh-112898: warn about unsaved files when quitting IDLE on macOS #112939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Dec 10, 2023

Implement the TK function ::tk::mac::Quit on macOS to ensure that IDLE asks about saving unsaved files when quitting IDLE.

Co-authored-by: Christopher Chavez chrischavez@gmx.us

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE.
@terryjreedy terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 11, 2023
@terryjreedy terryjreedy self-assigned this Dec 11, 2023
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug on Catalina, which I now realize also has the bug. Please merge if you think ready or ask me to.

@ronaldoussoren ronaldoussoren merged commit 3251ba8 into python:main Dec 11, 2023
@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@ronaldoussoren ronaldoussoren deleted the gh-112898 branch December 11, 2023 14:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
…pythonGH-112939)

* pythongh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE.

(cherry picked from commit 3251ba8)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Co-authored-by: Christopher Chavez chrischavez@gmx.us
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2023

GH-112960 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
…pythonGH-112939)

* pythongh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE.

(cherry picked from commit 3251ba8)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Co-authored-by: Christopher Chavez chrischavez@gmx.us
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2023

GH-112961 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 11, 2023
ronaldoussoren added a commit that referenced this pull request Dec 11, 2023
GH-112939) (#112960)

gh-112898: warn about unsaved files when quitting IDLE on macOS (GH-112939)

* gh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE.

(cherry picked from commit 3251ba8)


Co-authored-by: Christopher Chavez chrischavez@gmx.us

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this pull request Dec 11, 2023
GH-112939) (#112961)

gh-112898: warn about unsaved files when quitting IDLE on macOS (GH-112939)

* gh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE.

(cherry picked from commit 3251ba8)


Co-authored-by: Christopher Chavez chrischavez@gmx.us

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…python#112939)

* pythongh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE. 

Co-authored-by: Christopher Chavez chrischavez@gmx.us
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…python#112939)

* pythongh-112898: warn about unsaved files when quitting IDLE on macOS

Implement the TK function ``::tk::mac::Quit`` on macOS to
ensure that IDLE asks about saving unsaved files when
quitting IDLE. 

Co-authored-by: Christopher Chavez chrischavez@gmx.us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants