Skip to content

gh-111417: Remove unused code block in math.trunc() and builtin_round_impl #111454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2024
Merged

gh-111417: Remove unused code block in math.trunc() and builtin_round_impl #111454

merged 1 commit into from
Feb 3, 2024

Conversation

Jason-Y-Z
Copy link
Contributor

@Jason-Y-Z Jason-Y-Z commented Oct 29, 2023 •
edited
Loading

Remove unused code block in math.trunc() and builtin_round_impl as mentioned in #111417

@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2023
Closed
@skirpichev
Copy link
Member

I suggest adding some text explaining reasons for removal. Either in the commit message or in the pr description (which may become a commit message).

@Jason-Y-Z
Copy link
Contributor Author

@serhiy-storchaka sorry for asking but any thoughts?

serhiy-storchaka
serhiy-storchaka reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have said on the issue, this change looks safe to me. Do you mind to remove also a similar code in round()?

@Jason-Y-Z Jason-Y-Z changed the title gh-111417: Remove unused code block in math.trunc() gh-111417: Remove unused code block in math.trunc() and builtin_round_impl Feb 3, 2024
@Jason-Y-Z
Copy link
Contributor Author

As I have said on the issue, this change looks safe to me. Do you mind to remove also a similar code in round()?

Sorry for the delay, I've made the updates. @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit efc4890 into python:main Feb 3, 2024
@Jason-Y-Z Jason-Y-Z deleted the fix-issue-111417 branch February 3, 2024 19:40
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Jason-Y-Z @aisk
pythongh-111417: Remove unused code block in math.trunc() and round() (…
6ee8a57 
…pythonGH-111454)

_PyObject_LookupSpecial() now ensures that the type is ready.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@Jason-Y-Z @fsc-eriker
pythongh-111417: Remove unused code block in math.trunc() and round() (…
8e8de6c 
…pythonGH-111454)

_PyObject_LookupSpecial() now ensures that the type is ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jason-Y-Z @skirpichev @willingc @serhiy-storchaka