Skip to content

gh-100227: Lock Around Modification of the Global Allocators State #105516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 8, 2023

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review June 8, 2023 18:53
@ericsnowcurrently ericsnowcurrently removed the needs backport to 3.12 only security fixes label Jun 8, 2023
@ericsnowcurrently ericsnowcurrently merged commit 68dfa49 into python:main Jun 8, 2023
@ericsnowcurrently ericsnowcurrently deleted the allocators-state-granular-lock branch June 8, 2023 20:06
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.12 only security fixes label Jun 8, 2023
@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
…ate (pythongh-105516)

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.
(cherry picked from commit 68dfa49)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-bot
Copy link

GH-105532 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2023
…tate (gh-105516) (gh-105532)

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.
(cherry picked from commit 68dfa49)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants