Skip to content

ctypes pointer set_type doesn't cache when setting _type_ #133290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
encukou opened this issue May 2, 2025 · 0 comments
Closed

ctypes pointer set_type doesn't cache when setting _type_ #133290

encukou opened this issue May 2, 2025 · 0 comments
Assignees
@encukou
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented May 2, 2025 •
edited by bedevere-app bot
Loading

Bug report

In #114314 (3.13) I introduced a regression: set_type misuses PyType_GetDict by modifying it.

import ctypes
intptr = ctypes.POINTER(ctypes.c_int)
print(intptr._type_)  # uncomment to hide the issue
print(intptr._type_)
intptr.set_type(ctypes.c_float)  # a bad idea, but, it should set _type_
print(intptr._type_)

Linked PRs
@encukou encukou added 3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels May 2, 2025
@encukou encukou self-assigned this May 2, 2025
encukou added a commit to encukou/cpython that referenced this issue May 2, 2025
@encukou
pythongh-133290: Use PyObject_SetAttr to set _type_
f475056
@bedevere-app bedevere-app bot mentioned this issue May 2, 2025
Merged
encukou added a commit that referenced this issue May 2, 2025
@encukou
gh-133290: Use PyObject_SetAttr to set _type_ (GH-133292)
2590774
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 2, 2025
@encukou @miss-islington
pythongh-133290: Use PyObject_SetAttr to set _type_ (pythonGH-133292)
7420697 
(cherry picked from commit 2590774)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue May 2, 2025
Merged
encukou added a commit that referenced this issue May 2, 2025
@miss-islington @encukou
[3.13] gh-133290: Use PyObject_SetAttr to set _type_ (GH-133292) (GH-…
e75f528 
…133295)

gh-133290: Use PyObject_SetAttr to set _type_ (GH-133292)
(cherry picked from commit 2590774)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou closed this as completed May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@encukou encukou

Labels
3.13 bugs and security fixes 3.14 bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@encukou