Skip to content

Handle error correctly in PyFloat_GetInfo #116714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Mar 13, 2024 · 0 comments
Closed

Handle error correctly in PyFloat_GetInfo #116714

sobolevn opened this issue Mar 13, 2024 · 0 comments
Assignees
@sobolevn
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Mar 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

floatobject contains this code:

cpython/Objects/floatobject.c

Lines 101 to 123 in ba82a24

#define SetIntFlag(flag) \
PyStructSequence_SET_ITEM(floatinfo, pos++, PyLong_FromLong(flag))
#define SetDblFlag(flag) \
PyStructSequence_SET_ITEM(floatinfo, pos++, PyFloat_FromDouble(flag))
SetDblFlag(DBL_MAX);
SetIntFlag(DBL_MAX_EXP);
SetIntFlag(DBL_MAX_10_EXP);
SetDblFlag(DBL_MIN);
SetIntFlag(DBL_MIN_EXP);
SetIntFlag(DBL_MIN_10_EXP);
SetIntFlag(DBL_DIG);
SetIntFlag(DBL_MANT_DIG);
SetDblFlag(DBL_EPSILON);
SetIntFlag(FLT_RADIX);
SetIntFlag(FLT_ROUNDS);
#undef SetIntFlag
#undef SetDblFlag
if (PyErr_Occurred()) {
Py_CLEAR(floatinfo);
return NULL;
}

It only shows the last error and swallows any others.

I propose to change the error handling with the smallest possible diff.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 13, 2024
@sobolevn sobolevn self-assigned this Mar 13, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 13, 2024
@sobolevn
pythongh-116714: Handle errors correctly in PyFloat_GetInfo
81e9382
@bedevere-app bedevere-app bot mentioned this issue Mar 13, 2024
Merged
sobolevn added a commit that referenced this issue Mar 13, 2024
@sobolevn @serhiy-storchaka
gh-116714: Handle errors correctly in PyFloat_GetInfo (#116715)
fcd49b4 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @serhiy-storchaka @miss-islington
pythongh-116714: Handle errors correctly in PyFloat_GetInfo (python…
9be60db 
…GH-116715)

(cherry picked from commit fcd49b4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @serhiy-storchaka @miss-islington
pythongh-116714: Handle errors correctly in PyFloat_GetInfo (python…
33be0cd 
…GH-116715)

(cherry picked from commit fcd49b4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Mar 13, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Mar 13, 2024
@miss-islington @sobolevn @serhiy-storchaka
[3.11] gh-116714: Handle errors correctly in PyFloat_GetInfo (GH-11…
bccd1f6 
…6715) (#116723)

gh-116714: Handle errors correctly in `PyFloat_GetInfo` (GH-116715)
(cherry picked from commit fcd49b4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
sobolevn added a commit that referenced this issue Mar 13, 2024
@miss-islington @sobolevn @serhiy-storchaka
[3.12] gh-116714: Handle errors correctly in PyFloat_GetInfo (GH-11…
fc81b64 
…6715) (#116722)

gh-116714: Handle errors correctly in `PyFloat_GetInfo` (GH-116715)
(cherry picked from commit fcd49b4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@sobolevn @serhiy-storchaka @vstinner
pythongh-116714: Handle errors correctly in PyFloat_GetInfo (python…
f6ba89d 
…#116715)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@sobolevn @serhiy-storchaka @adorilson
pythongh-116714: Handle errors correctly in PyFloat_GetInfo (python…
e8ca2d8 
…#116715)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @serhiy-storchaka @diegorusso
pythongh-116714: Handle errors correctly in PyFloat_GetInfo (python…
5928270 
…#116715)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@sobolevn sobolevn mentioned this issue May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn