Skip to content

Updated Font Awesome to version 6.2.0 from 4.6.3 #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

sujithkdola
Copy link
Contributor

Changelog

Updated Font Awesome to Version 6.2.0

Files Changes:

./folium/folium.py

Closes

Closes Issues #1532 and #923

Screenshots

before
Before

after
After

Example

    import folium

    start_coords = (40.009515, -105.242714)

    folium_map = folium.Map(location=start_coords, zoom_start=5)

    folium.Marker(location=[41.009515, -105.242714],icon=folium.Icon(color="black",icon="fa-solid fa-satellite",prefix="fa")).add_to(folium_map)

    folium.Marker(location=[42.009515, -105.242714],icon=folium.Icon(color="black",icon="fa-solid fa-yin-yang",prefix="fa")).add_to(folium_map)

    folium.Marker(location=[43.009515, -105.242714],icon=folium.Icon(color="black",icon="fa-solid fa-volcano",prefix="fa")).add_to(folium_map)

    folium.Marker(location=[44.009515, -105.242714],icon=folium.Icon(color="black",icon="fa-solid fa-viruses",prefix="fa")).add_to(folium_map)

    folium.Marker(location=[45.009515, -105.242714],icon=folium.Icon(color="black",icon="fa-solid fa-wallet",prefix="fa")).add_to(folium_map)

@Conengmo
Copy link
Member

Conengmo commented Nov 7, 2022

Looks like the upgrade from Font Awesome 4 to 6 is seamless for the regular icons! That's good news. I tested this with an icon that was added in 6.2 and it worked with the current Awesome Markers code: Icon(icon='worm', prefix='fa')

For non-standard groups it also works, like you already showed in the PR description: Icon(icon='fa-brands fa-discord', prefix='fa').

Test failure is unrelated so this is ready to go.

@Conengmo Conengmo added the ready PR is ready for merging label Nov 7, 2022
@ocefpaf ocefpaf merged commit 7f50b40 into python-visualization:main Nov 8, 2022
@Conengmo
Copy link
Member

Conengmo commented Nov 9, 2022

Thanks for your help @Sujithkumardola!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants