Skip to content

Add short flag for --process-dependency-links #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

carlosdanielcsantos
Copy link

Adds -L as a short alternative for --process-dependency-links.

Closes #5112

@carlosdanielcsantos
Copy link
Author

Is this Travis fail a fluke? Should I push something meaningless just for it to run again or is there a procedure to do that?

@benoit-pierre
Copy link
Member

It does look like it, I've restarted the jobs.

@pradyunsg
Copy link
Member

@pypa/pip-committers Do we want this?

@benoit-pierre
Copy link
Member

benoit-pierre commented Mar 26, 2018

I'm not in favor of adding a short option for a deprecated option, especially if the issue is it's too long to type: there are a number of way to fix this locally; e.g. use a shell alias.

@pfmoore
Copy link
Member

pfmoore commented Mar 26, 2018

I'm a pretty strong -1 on this. Basically for all the reasons @benoit-pierre stated.

@pradyunsg
Copy link
Member

We should decide on #5112 if we want this, if (and when) the --dependency-links option is undeprecated. Until then, I think the reason for which this shorthand isn't going to be added is clear: not making it easier for someone to use a deprecated option.

I'm gonna close this PR because I don't want it bitrotting by then.

Sorry @carlosdanielcsantos and thanks for the contribution. ^>^

@pradyunsg pradyunsg closed this Apr 13, 2018
@carlosdanielcsantos
Copy link
Author

I found an even better way to do it. Just set this environment variable

PIP_PROCESS_DEPENDENCY_LINKS=1

And pip will always use --process-dependency-links

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short for --process-dependency-links
4 participants