Update notebooks with current API #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
reviewed
Oct 13, 2016
| " s = GaussianRandomWalk('s', sigma ** -2, shape=n)\n", | ||
| "\n", | ||
| " r = StudentT('r', nu, lam=exp(-2 * s), observed=returns)\n", | ||
| " r = StudentT('r', nu, lam=np.exp(-2 * s), observed=returns)\n", |
There was a problem hiding this comment.
Shouldn't that be pymc3.math.exp?
twiecki
reviewed
Oct 13, 2016
| flat_names = {v: create_flat_names(v, shape) | ||
| for v, shape in var_shapes.items() | ||
| if not v.endswith('_')} | ||
| flat_names = {v: create_flat_names(v, shape) for v, shape in var_shapes.items()} |
There was a problem hiding this comment.
Ah, you mentioned that. Perhaps we can add a kwarg like hide_transformed_vars?
ColCarroll
force-pushed
the
fix_examples
branch
from
d473af1 to
56689eb
Compare
twiecki
reviewed
Oct 14, 2016
| @@ -23,11 +23,11 @@ def trace_to_dataframe(trace, chains=None, flat_names=None): | |||
| if flat_names is None: | |||
| flat_names = {v: create_flat_names(v, shape) | |||
| for v, shape in var_shapes.items() | |||
| if not v.endswith('_')} | |||
| if not hide_transformed_vars or not v.endswith('_')} | |||
There was a problem hiding this comment.
equivalent to the more readable: if not (hide_transformed_vars and v.endswith('_'))
There was a problem hiding this comment.
@ColCarroll If you changes this we can merge this.
|
Missed that one, sorry! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly making sure imports still worked, restarting kernels and running the code all the way through. Did not check much for accuracy or soundness of approaches.
The only substantive change was in
trace_to_dataframe, which now includes transformed variables. One of the notebooks requires this to run, and it made sense to me that a user can filter columns more easily than recreating the dropped ones, but I can revert that if there are objections.This was all run in python 3.5, using the environment we build on travis, with a few extra libraries installed manually if the notebook required it.
Fixes #1444 , except for
pmf-pymc, which has a separate issue (#830).