Skip to content

[ENH] Method for adding functionality to pandas groupby #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

[ENH] Method for adding functionality to pandas groupby #1462

wants to merge 16 commits into from

Conversation

samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • Create function that allows creation of methods on pandas GroupBy objects, similar to the accessors/methods we have for pd.Series/pd.DataFrame
  • Extend jn.select to pandas GroupBy object - df.groupby('a').select('col_*')

This PR resolves #587 .

Please tag maintainers to review.

@samukweku samukweku self-assigned this Apr 8, 2025
@samukweku samukweku linked an issue Apr 8, 2025 that may be closed by this pull request
[ENH] Method for adding functionality to GroupBy #587
Open
@samukweku samukweku changed the title [ENH] METHOD FOR ADDING FUNCTIONALITY TO PANDAS GROUPBY [ENH] Method for adding functionality to pandas groupby Apr 8, 2025
@ericmjl
Copy link
Member

ericmjl commented Apr 8, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-1462--pyjanitor.netlify.app

ericmjl
ericmjl approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving! Just wanted to think twice about the name pull -- it defines the API, so it's worth thinking more deeply about this.

@samukweku
Copy link
Collaborator Author

@ericmjl can I get your review again for #1460

@samukweku samukweku requested a review from ericmjl April 30, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Awaiting requested review from Zsailer

@zbarry zbarry Awaiting requested review from zbarry

@thatlittleboy thatlittleboy Awaiting requested review from thatlittleboy

@ericmjl ericmjl Awaiting requested review from ericmjl

Assignees

@samukweku samukweku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Method for adding functionality to GroupBy
2 participants
@samukweku @ericmjl