Skip to content

Fully deprecate squeeze kwarg to groupby #9280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Fully deprecate squeeze kwarg to groupby #9280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
71f46b4
Fully deprecate squeeze kwarg to groupby
dcherian Jul 26, 2024
1f92b83
Fix doctests
dcherian Jul 26, 2024
665ede8
Update xarray/core/groupby.py
dcherian Jul 26, 2024
91ee85a
Fix whats-new
dcherian Jul 26, 2024
9cd323a
Update doc/whats-new.rst
dcherian Jul 26, 2024
06d27b2
Merge branch 'main' into delete-groupby-squeeze
dcherian Jul 26, 2024
78d695c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ Breaking changes
``origin`` or ``offset`` parameters is recommended as a replacement for using
the ``base`` parameter and using time offset arithmetic is recommended as a
replacement for using the ``loffset`` parameter.


Deprecations
~~~~~~~~~~~~
- The ``squeeze`` kwarg to ``groupby`` is completely deprecated. This has been the source of some quite confusing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might phrase this as "no longer supported" rather than "completely deprecated".

behaviour and has been deprecated since v2024.01.0. `groupby`` behavior is now always consistent
with the existing ``.groupby(..., squeeze=False)`` behavior.
By `Deepak Cherian <https://github.com/dcherian>`_. (:pull:`9280`)


Bug fixes
Expand Down
Loading
Loading