Skip to content

docs: preparing the Translation Files for Japanese #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Aug 2, 2024

@tkoyama010 tkoyama010 marked this pull request as ready for review August 2, 2024 09:11
@tkoyama010
Copy link
Member Author

pre-commit.ci autofix

@tkoyama010 tkoyama010 changed the title Create empty translation files for Japanese Preparing the Translation Files for Japanese Aug 2, 2024
@tkoyama010
Copy link
Member Author

Once this PR is merged, proceed to the next step of Translation Guide for the Python Packaging Guide.

Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for excluding the changes on the "es" files! The only comment is that we should use the iso code for Japanese (jp) instead of ja for the folder.

@tkoyama010
Copy link
Member Author

Thanks for excluding the changes on the "es" files! The only comment is that we should use the iso code for Japanese (jp) instead of ja for the folder.

Good catch. Thanks!

@tkoyama010 tkoyama010 requested a review from flpm August 2, 2024 09:29
@tkoyama010 tkoyama010 marked this pull request as draft August 2, 2024 09:44
@tkoyama010
Copy link
Member Author

Thanks for excluding the changes on the "es" files! The only comment is that we should use the iso code for Japanese (jp) instead of ja for the folder.

The code language option for Japanese is ja in Sphinx Options for internationalization. Could you explain the reason we use iso code?

@tkoyama010
Copy link
Member Author

tkoyama010 commented Aug 2, 2024

The Wikipedia description is most likely incorrect 😢 : jp is the Japan code and ja is the Japanese code.

@flpm
Copy link
Member

flpm commented Aug 2, 2024

Interesting, good catch! I wonder why they deviated from the standard. Keeping to the standard helps with language detection, so tools can recognize that a locale exists for a certain language automatically.

In our case, the important part is matching the theme locale code, because part of the text that appears comes from the Sphinx theme (pydata) and for it to work well they have to match.

I just checked and the theme does not have a Japanese locale yet, so no answer there.

I think it's probably better then to stick to the Sphinx code (ja), assuming that is what themes would also choose for their locales.

@tkoyama010
Copy link
Member Author

Thanks, it seems that Wikipedia was not wrong but the part I was referring to. The codes are different for country codes and language codes, and for language codes it is correct to look at IETF language tag. I will send a separate Pull Request for this!

@flpm
Copy link
Member

flpm commented Aug 2, 2024

The Wikipedia description is most likely incorrect 😢 : jp is the Japan code and ja is the Japanese code.

Ah, I guess it makes more sense then. We should then refer to the language, ja would be the correct code to use.

@tkoyama010
Copy link
Member Author

pre-commit.ci autofix

@tkoyama010 tkoyama010 marked this pull request as ready for review August 2, 2024 10:25
@tkoyama010 tkoyama010 changed the title Preparing the Translation Files for Japanese docs: preparing the Translation Files for Japanese Aug 2, 2024
@tkoyama010
Copy link
Member Author

I have no idea about CI error🙇

@willingc
Copy link
Collaborator

willingc commented Aug 5, 2024

Hi @tkoyama010. #356 should fix the htmlproofer error. Thanks for this PR 🎉

@willingc willingc added the translations Translation and localization of content label Aug 5, 2024
@lwasser
Copy link
Member

lwasser commented Aug 7, 2024

@all-contributors please add @tkoyama010 for code, review

Copy link
Contributor

@lwasser

I've put up a pull request to add @tkoyama010! 🎉

@lwasser
Copy link
Member

lwasser commented Aug 7, 2024

hey @flpm i'm happy for you to merge these translation related pr's as you see fit if you are ok with doing so!

Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's exciting to start a new language translation!

@flpm flpm merged commit 0786310 into pyOpenSci:main Aug 7, 2024
3 checks passed
@tkoyama010 tkoyama010 deleted the ja branch August 8, 2024 08:54
@flpm flpm added the lang-JA label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-JA translations Translation and localization of content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I would like to start the translation of the guide into Japanese
4 participants