-
Notifications
You must be signed in to change notification settings - Fork 59
docs: preparing the Translation Files for Japanese #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pre-commit.ci autofix |
Once this PR is merged, proceed to the next step of Translation Guide for the Python Packaging Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for excluding the changes on the "es" files! The only comment is that we should use the iso code for Japanese (jp) instead of ja for the folder.
Good catch. Thanks! |
The code language option for Japanese is ja in Sphinx Options for internationalization. Could you explain the reason we use iso code? |
|
Interesting, good catch! I wonder why they deviated from the standard. Keeping to the standard helps with language detection, so tools can recognize that a locale exists for a certain language automatically. In our case, the important part is matching the theme locale code, because part of the text that appears comes from the Sphinx theme (pydata) and for it to work well they have to match. I just checked and the theme does not have a Japanese locale yet, so no answer there. I think it's probably better then to stick to the Sphinx code (ja), assuming that is what themes would also choose for their locales. |
Thanks, it seems that Wikipedia was not wrong but the part I was referring to. The codes are different for country codes and language codes, and for language codes it is correct to look at IETF language tag. I will send a separate Pull Request for this! |
Ah, I guess it makes more sense then. We should then refer to the language, ja would be the correct code to use. |
pre-commit.ci autofix |
I have no idea about CI error🙇 |
Hi @tkoyama010. #356 should fix the htmlproofer error. Thanks for this PR 🎉 |
@all-contributors please add @tkoyama010 for code, review |
I've put up a pull request to add @tkoyama010! 🎉 |
hey @flpm i'm happy for you to merge these translation related pr's as you see fit if you are ok with doing so! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's exciting to start a new language translation!
resolve #352
ref Preparing the Translation Files