Combine read_nsrdb_psm4 and parse_nsrdb_psm4
#2445
Open
+121
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wholmgren
reviewed
Apr 23, 2025
AdamRJensen
approved these changes
Apr 27, 2025
| :py:func:`~pvlib.iotools.read_nsrdb_psm4`, and | ||
| :py:func:`~pvlib.iotools.parse_nsrdb_psm4`. (:issue:`2326`, :pull:`2378`) | ||
| :py:func:`~pvlib.iotools.get_nsrdb_psm4_full_disc`, and | ||
| :py:func:`~pvlib.iotools.read_nsrdb_psm4`. (:issue:`2326`, :pull:`2378`) |
There was a problem hiding this comment.
Suggested change
| :py:func:`~pvlib.iotools.read_nsrdb_psm4`. (:issue:`2326`, :pull:`2378`) | |
| :py:func:`~pvlib.iotools.read_nsrdb_psm4`. (:issue:`2326`, :pull:`2378`, | |
| :pull:`2445`) |
Comment on lines
+749
to
+751
| dtypes.update(Year=int, Month=int, Day=int, Hour=int, Minute=int) | ||
| dtypes['Cloud Type'] = int | ||
| dtypes['Fill Flag'] = int |
There was a problem hiding this comment.
Why can't Cloud type and Fill flag be updated the same way as the Year/Month?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_iotools functions #2444docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.As proposed in #2444. I also cleaned up some unrelated docs cruft; sorry for the noise.