-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update singlediode.bishop88
parameter types in docs
#1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 for the reverse bias parameters I'm not sure about making the recombination current term parameters |
Since the code already works when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reepoi
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reepoi!
breakdown_factor
type insinglediode.bishop88
docs #1820[ ] Tests added[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Update docs of
singlediode.bishop88*
functions to say that the parameters related to the bishop88 modeland PVSystare float types, not numeric.I explored the option of modifying these functions to support a numeric
breakdown_factor
and found that it significantly slows down the common case whenbreakdown_factor = 0
. Here is the Jupyter notebook I used to measure bishop88 performance: https://github.com/reepoi/pvlib-python/blob/bishop88-if/bishop88_speed.ipynbThe notebook compares three implementations of bishop88:
where
parameter to have numpy skip computing np.power when breakdown_factor is zeroThere are two tests in the notebook: