Skip to content

Refactor CEC SDM fit test #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peque opened this issue Apr 25, 2020 · 2 comments
Closed

Refactor CEC SDM fit test #956

Peque opened this issue Apr 25, 2020 · 2 comments
Labels
Milestone

Comments

@Peque
Copy link
Contributor

Peque commented Apr 25, 2020

It feels like test_fit_sdm_cec_sam() could be split into two:

  • Check for expected vs. actual output
  • Check for exception when the parameters cannot be estimated

The code under the with statement has no relation with the code above.

Peque added a commit to Peque/pvlib-python that referenced this issue Apr 25, 2020
@cwhanse
Copy link
Member

cwhanse commented Apr 25, 2020

This is a good suggestion. I'll roll the changes in #956 into #708 which refactors all of pvlib.ivtools. Please leave both #956 and #957 open for now.

@CameronTStark CameronTStark added this to the 0.7.3 milestone Apr 27, 2020
@CameronTStark CameronTStark removed this from the 0.7.3 milestone May 26, 2020
@wholmgren wholmgren added this to the 0.8.0 milestone Jul 17, 2020
@cwhanse
Copy link
Member

cwhanse commented Aug 26, 2020

Closed via #708, test function split into test_fit_cec_sam and test_fit_cec_sam_estimation_failure

@cwhanse cwhanse closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants