Skip to content

fix: event name conflicts with other libs using RCTDeviceEventEmitter #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 25, 2023
Merged

fix: event name conflicts with other libs using RCTDeviceEventEmitter #70

merged 6 commits into from
Jan 25, 2023

Conversation

fbenevides
Copy link
Contributor

Description

  • Add event prefix to all events sent by Pusher module

Fixes #54

CHANGELOG

  • [FIXED] Fixed event name conflicts with other libs using RCTDeviceEventEmitter

@fbenevides fbenevides requested a review from amad January 24, 2023 23:08
@fbenevides fbenevides merged commit 0ec7faf into master Jan 25, 2023
@fbenevides fbenevides deleted the fix-global-event-emitter branch January 25, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amad amad Awaiting requested review from amad

Assignees
No one assigned
Labels
release-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict with other react-native modules (other libs using RCTDeviceEventEmitter with same event names)
2 participants
@fbenevides @pusher-ci