Lint/AssignmentInCondition #9316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
maint/main/assignmentincondition
branch
from
70e588b to
2cd8d29
Compare
joshcooper
reviewed
Apr 8, 2024
Prior to this commit the static loader class used variable assignment in conditionals unnecessarily and made a comparison (name_authority == Pcore::RUNTIME_NAME_AUTHORITY) that was always true. This commit simplifies the conditionals to both remove the redundant comparison and variable assignment in conditional.
mhashizume
force-pushed
the
maint/main/assignmentincondition
branch
from
2cd8d29 to
1e888de
Compare
This commit takes variable assignments in conditionals and wraps them in parentheses to make the intention more explicit.
mhashizume
force-pushed
the
maint/main/assignmentincondition
branch
from
1e888de to
0cf25bb
Compare
joshcooper
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes variable assignments in conditionals and wraps them in parentheses to make the intention more explicit.