Add support for undocumented query options for API #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `WithLookbackDelta` and `WithPerStepStats` options have been added to API client. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
mahendrapaipuri
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
kakkoyun
approved these changes
Feb 18, 2025
bwplotka
requested changes
Feb 19, 2025
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Mahendra Paipuri <44365948+mahendrapaipuri@users.noreply.github.com>
* Use a custom `StatsValue` type to provide as query parameter for `stats` option. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
ying-jeanne
pushed a commit
to ying-jeanne/client_golang
that referenced
this pull request
Mar 28, 2025
* refactor: Add support for undocumented query options for API * `WithLookbackDelta` and `WithPerStepStats` options have been added to API client. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com> * Update api/prometheus/v1/api.go Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Mahendra Paipuri <44365948+mahendrapaipuri@users.noreply.github.com> * refactor: Address PR comments and feedback * Use a custom `StatsValue` type to provide as query parameter for `stats` option. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com> --------- Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com> Signed-off-by: Mahendra Paipuri <44365948+mahendrapaipuri@users.noreply.github.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithLookbackDeltaandWithStatsoptions have been added to API client.lookback_deltacan be especially handy when dealing with mix of continuous and intermittent time series.