Upgrade Golang version v1.24 #1738
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,5 +62,5 @@ jobs: | |
| CI: true | ||
|
|
||
| - name: Run style and unused | ||
| if: ${{ matrix.go_version == '1.22' }} | ||
| run: make style unused | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/prometheus/client_golang | ||
|
|
||
| go 1.22 | ||
|
There was a problem hiding this comment. We don't need to bump this if we don't use any new APIs from 1.22. We officially support only the last three versions but if we don't use new APIs no need to break compatibly. There was a problem hiding this comment. Thanks @kakkoyun There was a problem hiding this comment. Except we do need to change it if we remove 1.21 from the supported version test matrix. There was a problem hiding this comment. You’re right—I’m still undecided on this. We could continue testing all versions down to the minimum required API level (1.21) since there’s no downside to doing so. That said, we could also make the case for upgrading the Go toolchain, given its strong backward compatibility. Better to stick what we have right now. There was a problem hiding this comment.
Thanks @SuperQ |
||
|
|
||
| require ( | ||
| github.com/beorn7/perks v1.0.1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,226 @@ | ||
| // Copyright 2022 The Prometheus Authors | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //go:build go1.24 && !go1.25 | ||
| // +build go1.24,!go1.25 | ||
|
|
||
| package collectors | ||
|
|
||
| func withAllMetrics() []string { | ||
| return withBaseMetrics([]string{ | ||
| "go_cgo_go_to_c_calls_calls_total", | ||
| "go_cpu_classes_gc_mark_assist_cpu_seconds_total", | ||
| "go_cpu_classes_gc_mark_dedicated_cpu_seconds_total", | ||
| "go_cpu_classes_gc_mark_idle_cpu_seconds_total", | ||
| "go_cpu_classes_gc_pause_cpu_seconds_total", | ||
| "go_cpu_classes_gc_total_cpu_seconds_total", | ||
| "go_cpu_classes_idle_cpu_seconds_total", | ||
| "go_cpu_classes_scavenge_assist_cpu_seconds_total", | ||
| "go_cpu_classes_scavenge_background_cpu_seconds_total", | ||
| "go_cpu_classes_scavenge_total_cpu_seconds_total", | ||
| "go_cpu_classes_total_cpu_seconds_total", | ||
| "go_cpu_classes_user_cpu_seconds_total", | ||
| "go_gc_cycles_automatic_gc_cycles_total", | ||
| "go_gc_cycles_forced_gc_cycles_total", | ||
| "go_gc_cycles_total_gc_cycles_total", | ||
| "go_gc_gogc_percent", | ||
| "go_gc_gomemlimit_bytes", | ||
| "go_gc_heap_allocs_by_size_bytes", | ||
| "go_gc_heap_allocs_bytes_total", | ||
| "go_gc_heap_allocs_objects_total", | ||
| "go_gc_heap_frees_by_size_bytes", | ||
| "go_gc_heap_frees_bytes_total", | ||
| "go_gc_heap_frees_objects_total", | ||
| "go_gc_heap_goal_bytes", | ||
| "go_gc_heap_live_bytes", | ||
| "go_gc_heap_objects_objects", | ||
| "go_gc_heap_tiny_allocs_objects_total", | ||
| "go_gc_limiter_last_enabled_gc_cycle", | ||
| "go_gc_pauses_seconds", | ||
| "go_gc_scan_globals_bytes", | ||
| "go_gc_scan_heap_bytes", | ||
| "go_gc_scan_stack_bytes", | ||
| "go_gc_scan_total_bytes", | ||
| "go_gc_stack_starting_size_bytes", | ||
| "go_godebug_non_default_behavior_asynctimerchan_events_total", | ||
| "go_godebug_non_default_behavior_execerrdot_events_total", | ||
| "go_godebug_non_default_behavior_gocachehash_events_total", | ||
| "go_godebug_non_default_behavior_gocachetest_events_total", | ||
| "go_godebug_non_default_behavior_gocacheverify_events_total", | ||
| "go_godebug_non_default_behavior_gotestjsonbuildtext_events_total", | ||
| "go_godebug_non_default_behavior_gotypesalias_events_total", | ||
| "go_godebug_non_default_behavior_http2client_events_total", | ||
| "go_godebug_non_default_behavior_http2server_events_total", | ||
| "go_godebug_non_default_behavior_httplaxcontentlength_events_total", | ||
| "go_godebug_non_default_behavior_httpmuxgo121_events_total", | ||
| "go_godebug_non_default_behavior_httpservecontentkeepheaders_events_total", | ||
| "go_godebug_non_default_behavior_installgoroot_events_total", | ||
| "go_godebug_non_default_behavior_multipartmaxheaders_events_total", | ||
| "go_godebug_non_default_behavior_multipartmaxparts_events_total", | ||
| "go_godebug_non_default_behavior_multipathtcp_events_total", | ||
| "go_godebug_non_default_behavior_netedns0_events_total", | ||
| "go_godebug_non_default_behavior_panicnil_events_total", | ||
| "go_godebug_non_default_behavior_randautoseed_events_total", | ||
| "go_godebug_non_default_behavior_randseednop_events_total", | ||
| "go_godebug_non_default_behavior_rsa1024min_events_total", | ||
| "go_godebug_non_default_behavior_tarinsecurepath_events_total", | ||
| "go_godebug_non_default_behavior_tls10server_events_total", | ||
| "go_godebug_non_default_behavior_tls3des_events_total", | ||
| "go_godebug_non_default_behavior_tlsmaxrsasize_events_total", | ||
| "go_godebug_non_default_behavior_tlsrsakex_events_total", | ||
| "go_godebug_non_default_behavior_tlsunsafeekm_events_total", | ||
| "go_godebug_non_default_behavior_winreadlinkvolume_events_total", | ||
| "go_godebug_non_default_behavior_winsymlink_events_total", | ||
| "go_godebug_non_default_behavior_x509keypairleaf_events_total", | ||
| "go_godebug_non_default_behavior_x509negativeserial_events_total", | ||
| "go_godebug_non_default_behavior_x509rsacrt_events_total", | ||
| "go_godebug_non_default_behavior_x509usefallbackroots_events_total", | ||
| "go_godebug_non_default_behavior_x509usepolicies_events_total", | ||
| "go_godebug_non_default_behavior_zipinsecurepath_events_total", | ||
| "go_memory_classes_heap_free_bytes", | ||
| "go_memory_classes_heap_objects_bytes", | ||
| "go_memory_classes_heap_released_bytes", | ||
| "go_memory_classes_heap_stacks_bytes", | ||
| "go_memory_classes_heap_unused_bytes", | ||
| "go_memory_classes_metadata_mcache_free_bytes", | ||
| "go_memory_classes_metadata_mcache_inuse_bytes", | ||
| "go_memory_classes_metadata_mspan_free_bytes", | ||
| "go_memory_classes_metadata_mspan_inuse_bytes", | ||
| "go_memory_classes_metadata_other_bytes", | ||
| "go_memory_classes_os_stacks_bytes", | ||
| "go_memory_classes_other_bytes", | ||
| "go_memory_classes_profiling_buckets_bytes", | ||
| "go_memory_classes_total_bytes", | ||
| "go_sched_gomaxprocs_threads", | ||
| "go_sched_goroutines_goroutines", | ||
| "go_sched_latencies_seconds", | ||
| "go_sched_pauses_stopping_gc_seconds", | ||
| "go_sched_pauses_stopping_other_seconds", | ||
| "go_sched_pauses_total_gc_seconds", | ||
| "go_sched_pauses_total_other_seconds", | ||
| "go_sync_mutex_wait_total_seconds_total", | ||
| }) | ||
| } | ||
|
|
||
| func withGCMetrics() []string { | ||
| return withBaseMetrics([]string{ | ||
| "go_gc_cycles_automatic_gc_cycles_total", | ||
| "go_gc_cycles_forced_gc_cycles_total", | ||
| "go_gc_cycles_total_gc_cycles_total", | ||
| "go_gc_gogc_percent", | ||
| "go_gc_gomemlimit_bytes", | ||
| "go_gc_heap_allocs_by_size_bytes", | ||
| "go_gc_heap_allocs_bytes_total", | ||
| "go_gc_heap_allocs_objects_total", | ||
| "go_gc_heap_frees_by_size_bytes", | ||
| "go_gc_heap_frees_bytes_total", | ||
| "go_gc_heap_frees_objects_total", | ||
| "go_gc_heap_goal_bytes", | ||
| "go_gc_heap_live_bytes", | ||
| "go_gc_heap_objects_objects", | ||
| "go_gc_heap_tiny_allocs_objects_total", | ||
| "go_gc_limiter_last_enabled_gc_cycle", | ||
| "go_gc_pauses_seconds", | ||
| "go_gc_scan_globals_bytes", | ||
| "go_gc_scan_heap_bytes", | ||
| "go_gc_scan_stack_bytes", | ||
| "go_gc_scan_total_bytes", | ||
| "go_gc_stack_starting_size_bytes", | ||
| }) | ||
| } | ||
|
|
||
| func withMemoryMetrics() []string { | ||
| return withBaseMetrics([]string{ | ||
| "go_memory_classes_heap_free_bytes", | ||
| "go_memory_classes_heap_objects_bytes", | ||
| "go_memory_classes_heap_released_bytes", | ||
| "go_memory_classes_heap_stacks_bytes", | ||
| "go_memory_classes_heap_unused_bytes", | ||
| "go_memory_classes_metadata_mcache_free_bytes", | ||
| "go_memory_classes_metadata_mcache_inuse_bytes", | ||
| "go_memory_classes_metadata_mspan_free_bytes", | ||
| "go_memory_classes_metadata_mspan_inuse_bytes", | ||
| "go_memory_classes_metadata_other_bytes", | ||
| "go_memory_classes_os_stacks_bytes", | ||
| "go_memory_classes_other_bytes", | ||
| "go_memory_classes_profiling_buckets_bytes", | ||
| "go_memory_classes_total_bytes", | ||
| }) | ||
| } | ||
|
|
||
| func withSchedulerMetrics() []string { | ||
| return withBaseMetrics([]string{ | ||
| "go_sched_gomaxprocs_threads", | ||
| "go_sched_goroutines_goroutines", | ||
| "go_sched_latencies_seconds", | ||
| "go_sched_pauses_stopping_gc_seconds", | ||
| "go_sched_pauses_stopping_other_seconds", | ||
| "go_sched_pauses_total_gc_seconds", | ||
| "go_sched_pauses_total_other_seconds", | ||
| }) | ||
| } | ||
|
|
||
| func withDebugMetrics() []string { | ||
| return withBaseMetrics([]string{ | ||
| "go_godebug_non_default_behavior_asynctimerchan_events_total", | ||
| "go_godebug_non_default_behavior_execerrdot_events_total", | ||
| "go_godebug_non_default_behavior_gocachehash_events_total", | ||
| "go_godebug_non_default_behavior_gocachetest_events_total", | ||
| "go_godebug_non_default_behavior_gocacheverify_events_total", | ||
| "go_godebug_non_default_behavior_gotestjsonbuildtext_events_total", | ||
| "go_godebug_non_default_behavior_gotypesalias_events_total", | ||
| "go_godebug_non_default_behavior_http2client_events_total", | ||
| "go_godebug_non_default_behavior_http2server_events_total", | ||
| "go_godebug_non_default_behavior_httplaxcontentlength_events_total", | ||
| "go_godebug_non_default_behavior_httpmuxgo121_events_total", | ||
| "go_godebug_non_default_behavior_httpservecontentkeepheaders_events_total", | ||
| "go_godebug_non_default_behavior_installgoroot_events_total", | ||
| "go_godebug_non_default_behavior_multipartmaxheaders_events_total", | ||
| "go_godebug_non_default_behavior_multipartmaxparts_events_total", | ||
| "go_godebug_non_default_behavior_multipathtcp_events_total", | ||
| "go_godebug_non_default_behavior_netedns0_events_total", | ||
| "go_godebug_non_default_behavior_panicnil_events_total", | ||
| "go_godebug_non_default_behavior_randautoseed_events_total", | ||
| "go_godebug_non_default_behavior_randseednop_events_total", | ||
| "go_godebug_non_default_behavior_rsa1024min_events_total", | ||
| "go_godebug_non_default_behavior_tarinsecurepath_events_total", | ||
| "go_godebug_non_default_behavior_tls10server_events_total", | ||
| "go_godebug_non_default_behavior_tls3des_events_total", | ||
| "go_godebug_non_default_behavior_tlsmaxrsasize_events_total", | ||
| "go_godebug_non_default_behavior_tlsrsakex_events_total", | ||
| "go_godebug_non_default_behavior_tlsunsafeekm_events_total", | ||
| "go_godebug_non_default_behavior_winreadlinkvolume_events_total", | ||
| "go_godebug_non_default_behavior_winsymlink_events_total", | ||
| "go_godebug_non_default_behavior_x509keypairleaf_events_total", | ||
| "go_godebug_non_default_behavior_x509negativeserial_events_total", | ||
| "go_godebug_non_default_behavior_x509rsacrt_events_total", | ||
| "go_godebug_non_default_behavior_x509usefallbackroots_events_total", | ||
| "go_godebug_non_default_behavior_x509usepolicies_events_total", | ||
| "go_godebug_non_default_behavior_zipinsecurepath_events_total", | ||
| }) | ||
| } | ||
|
|
||
| var ( | ||
| defaultRuntimeMetrics = []string{ | ||
| "go_gc_gogc_percent", | ||
| "go_gc_gomemlimit_bytes", | ||
| "go_sched_gomaxprocs_threads", | ||
| } | ||
| onlyGCDefRuntimeMetrics = []string{ | ||
| "go_gc_gogc_percent", | ||
| "go_gc_gomemlimit_bytes", | ||
| } | ||
| onlySchedDefRuntimeMetrics = []string{ | ||
| "go_sched_gomaxprocs_threads", | ||
| } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.