Fix WebGL alpha blending #7769
Merged
Fix WebGL alpha blending #7769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7768
Changes:
When taking in a tint, the tint alpha also has to be multiplied with the other tint components.
We actually used to have this, but I "simplified" (broke) this when making a change to hide premultiplied alpha for shader hooks users. I actually even added tests before, but happened to pick test colors that are already maxed out, so you wouldn't be able to tell whether there was a problem or not. (I've updated the tests now to have some non-maxed out colors so that we can catch this if it breaks in the future.)
Screenshots of the change:
Before:
After:
Live: https://editor.p5js.org/davepagurek/sketches/MAOyCH3Hp
PR Checklist
npm run lintpasses