-
Notifications
You must be signed in to change notification settings - Fork 301
Fix and update types #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update types #257
Conversation
Hi @Minigugus .. Great to see you back, and thanks a lot for this!! All those things needs to have documentation written too, so that's also a thing needed before release, but just as you, I'm also quite busy. I'm done with a pretty big (complete) overhaul of the internals which I'll push soon, and I'm not really sure if it makes sense to bump to v3 instead. It includes the missing dynamic query function, so I think the only thing missing now for a release is getting docs and types up to date. |
@porsager Nice 👍 Can't wait for dynamic queries 😆 Since I'm busy, maybe these changes could be merged after a quick review so that anyone wanting to contribute to the documentation can do so? |
f31a852
to
5704fe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Minigugus - let me know when you think it's ready to merge and we'll go..
@porsager I would say it's ready. Some flaws may remain but most common use cases are covered and I don't have time to chase them and I don't want the release to be delayed again 🙂 |
Very cool, and understandable! Thanks @Minigugus ! |
TypeScript definitions are missing a lot a features (mostly
.raw()
,.readable()
,.writable()
,sql.subscribe()
and some new options)I tried to fix them before the v2 release. I also added default values for options in their descriptions, it can be useful for options that fallback to an environment variable when missing. It might be cool to add more documentation too but I'm busy these days 😕