Skip to content

Fix and update types #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix and update types #257

merged 2 commits into from
Jan 12, 2022

Conversation

Minigugus
Copy link
Contributor

TypeScript definitions are missing a lot a features (mostly .raw(), .readable(), .writable(), sql.subscribe() and some new options)

I tried to fix them before the v2 release. I also added default values for options in their descriptions, it can be useful for options that fallback to an environment variable when missing. It might be cool to add more documentation too but I'm busy these days 😕

@Minigugus Minigugus requested a review from porsager January 10, 2022 15:08
@porsager
Copy link
Owner

porsager commented Jan 10, 2022

Hi @Minigugus .. Great to see you back, and thanks a lot for this!!

All those things needs to have documentation written too, so that's also a thing needed before release, but just as you, I'm also quite busy.

I'm done with a pretty big (complete) overhaul of the internals which I'll push soon, and I'm not really sure if it makes sense to bump to v3 instead. It includes the missing dynamic query function, so I think the only thing missing now for a release is getting docs and types up to date.

@Minigugus
Copy link
Contributor Author

@porsager Nice 👍 Can't wait for dynamic queries 😆

Since I'm busy, maybe these changes could be merged after a quick review so that anyone wanting to contribute to the documentation can do so?

@porsager porsager changed the base branch from master to rewrite January 11, 2022 10:20
@porsager porsager force-pushed the rewrite branch 5 times, most recently from f31a852 to 5704fe1 Compare January 12, 2022 12:35
Copy link
Owner

@porsager porsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Minigugus - let me know when you think it's ready to merge and we'll go..

@Minigugus
Copy link
Contributor Author

@porsager I would say it's ready. Some flaws may remain but most common use cases are covered and I don't have time to chase them and I don't want the release to be delayed again 🙂

@porsager
Copy link
Owner

Very cool, and understandable! Thanks @Minigugus !

@porsager porsager merged commit 872529a into porsager:rewrite Jan 12, 2022
@Minigugus Minigugus deleted the fix-ts branch January 12, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants