-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add tidb index usage limitation for valid stats #20249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@lcwangchao: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@@ -91,6 +91,7 @@ DESC CLUSTER_TIDB_INDEX_USAGE; | |||
|
|||
- `TIDB_INDEX_USAGE` 表中的数据可能存在最多 5 分钟的延迟。 | |||
- 在 TiDB 重启后,`TIDB_INDEX_USAGE` 表中的数据会被清空。 | |||
- 只有在表具有有效统计信息时,才会记录该表的索引使用情况。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 只有在表具有有效统计信息时,才会记录该表的索引使用情况。 | |
- 只有在表具有有效统计信息时,TiDB 才会记录该表的索引使用情况。 |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
6008113
to
8f6e28a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add a limitation to the tidb usage limitation. The description is aligned with the "index-advisor.md":
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?