Skip to content

Update TiDB specific function docs #17980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 30, 2024
Merged

Update TiDB specific function docs #17980

merged 7 commits into from
Jul 30, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 16, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

  1. Make sure the page TOC links to the functions
  2. Remove argument description from the page TOC
  3. Add info for VITESS_HASH()
  4. Reorganize the functions in alphabetical order

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2024
@lilin90 lilin90 marked this pull request as draft July 16, 2024 07:09
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@lilin90 lilin90 self-assigned this Jul 16, 2024
@lilin90 lilin90 changed the title Update TIDB specific function docs Update TiDB specific function docs Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@lilin90 lilin90 marked this pull request as ready for review July 16, 2024 09:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@lilin90 lilin90 requested review from Oreoxmt and easonn7 July 16, 2024 09:26
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 24, 2024

@easonn7: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt mentioned this pull request Jul 24, 2024
Merged
16 tasks
Oreoxmt
Oreoxmt reviewed Jul 24, 2024
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-24 09:12:21.883683583 +0000 UTC m=+1036363.874625049: ☑️ agreed by Oreoxmt.

@lilin90 @Oreoxmt
Apply suggestions from code review
39353a6 
Co-authored-by: Aolin <aolinz@outlook.com>
@lilin90 lilin90 added the lgtm label Jul 30, 2024
@lilin90
Copy link
Member Author

lilin90 commented Jul 30, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 620ab20 into pingcap:master Jul 30, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18203.

This was referenced Jul 30, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18204.

@lilin90 lilin90 deleted the tidb_func_upd-17693 branch July 30, 2024 08:02
ti-chi-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@ti-chi-bot
Update TiDB specific function docs (#17980) (#18204)
de843dc
ti-chi-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@ti-chi-bot
Update TiDB specific function docs (#17980) (#18203)
e467bb1
This was referenced Jul 30, 2024
Merged
Merged
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 19, 2025
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 19, 2025
@lilin90 @ti-chi-bot
This is an automated cherry-pick of pingcap#17980
867960a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20230.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 19, 2025
Merged
17 tasks
Oreoxmt pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 19, 2025
@lilin90 @Oreoxmt
Update TiDB specific function docs (pingcap#17980)
97447ef
ti-chi-bot bot pushed a commit that referenced this pull request Apr 19, 2025
@ti-chi-bot
Update TiDB specific function docs (#17980) (#20230)
b917f24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@easonn7 easonn7 easonn7 approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilin90 @ti-chi-bot @Oreoxmt @easonn7