Skip to content

Fix Reeds-Shepp planner #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Conversation

hcarlsso
Copy link

Fixes the Reeds-Shepp planner and adds a unit test.

@petercorke petercorke changed the base branch from master to future April 29, 2023 23:53
@petercorke petercorke changed the base branch from future to master August 10, 2024 06:41
@petercorke petercorke changed the base branch from master to future August 10, 2024 06:48
@petercorke petercorke merged commit 48fe1d5 into petercorke:future Aug 10, 2024
@petercorke
Copy link
Owner

Thanks for your interest in the Toolbox, and for your PR. Accepted (with very minor change) into future branch.

@petercorke
Copy link
Owner

Hi @hcarlsso. I merged your code but the extra unit test you made fails for me. I get the turn sequence RLR whereas your test says the result should be LRL. Theoretically both sequences give the same result. The output of calc_paths that I get is:

[_Path: L=3.1, [L=1, R=-1, L=1], 35 points on path, _Path: L=3.1, [R=1, L=-1, R=1], 33 points on path]
special variables
function variables
0 =
_Path: L=3.1, [L=1, R=-1, L=1], 35 points on path
1 =
_Path: L=3.1, [R=1, L=-1, R=1], 33 points on path
len() =
2

which shows both paths have a length of 3.1 (pi). I suspect some very small arithmetic error makes my computer (MacOS+arm) choose RLR and your computer chooses LRL.

Can you please confirm your results and tell me what your platform is.

Bottom line, this is probably not a great example to use for a test given two possible answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants