Skip to content

fix fi overflow panic because of multi 'in values' in query text #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zanjie
Copy link

@zanjie zanjie commented Jun 7, 2021

the real reason that fi overflow cause index out of range panic is the length of variable f slice need increament when in values length in quota is less than 2

sql: select col1 from tb1 where cond1 in(1) and cond2 in(2);
Fingerprint(sql) got panic: index out of range
image

after fix
image

@zanjie zanjie requested a review from percona-csalguero as a code owner June 7, 2021 12:01
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #58 (d549e74) into master (3e7f9d3) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head d549e74 differs from pull request most recent head 79e0df8. Consider uploading reports for the commit 79e0df8 to get more accurate results

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   67.25%   67.07%   -0.19%     
==========================================
  Files           7        7              
  Lines        1408     1400       -8     
==========================================
- Hits          947      939       -8     
  Misses        349      349              
  Partials      112      112              
Impacted Files Coverage Δ
query/query.go 65.97% <100.00%> (+0.17%) ⬆️
log/slow/parser.go 70.80% <0.00%> (-1.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

TarmoKople pushed a commit to TarmoKople/go-mysql that referenced this pull request Feb 28, 2022
@it-percona-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ BupycHuk
❌ root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants