Skip to content

ci(bot): add issue bot #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 25, 2021

New Pull Request Checklist

Issue Description

Adds issue assistance when opening / reopening / editing a new issue.

Closes #7522

Approach

This is a custom bot, not to be published to the GitHub Actions Marketplace, currently with the following basic features:

  • Checks only issues, not PRs
  • Runs when opening / reopening / editing a new issue
  • Ensures top checkboxes are checked
  • Ensures issue template for bug / feature is used
  • Contains a "beta" note at the bottom, so that readers know it may not interpret the issue always correctly
  • Runs independently of existing CI, so should not influence it in any way
  • Costs 10 seconds GH Actions processing time per run --> that should be monitored, but given the other long CI runs, it is maybe negligible
  • Yes, I did name the bot Parsy (should probably remove that)

Here are some test issues to play around with and see the bot in action.
Simply toggle the checkboxes and wait 10 sec to see the bot message changing.

Screenshots

  • Incorrect template:
    image

  • Not all checkboxes checked:
    image

  • All checkboxes checked:
    image

Notes

  • Points to main branch of parse-issue-bot repo at the moment, because there will likely be rapid improvements needed during the beta rollout
  • GH Action is not configurable via YAML parameters, template references are hardcoded, so if a template headline changes, the bot would have to change too. That can be improved, but I would only run this for dashboard and parse server to start with, they share the same templates.

TODOs before merging

  • Add entry to changelog

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #7523 (955b9ee) into master (dee5a13) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 955b9ee differs from pull request most recent head 9b17745. Consider uploading reports for the commit 9b17745 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7523      +/-   ##
==========================================
- Coverage   93.97%   93.94%   -0.04%     
==========================================
  Files         181      181              
  Lines       13273    13273              
==========================================
- Hits        12473    12469       -4     
- Misses        800      804       +4     
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.37% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee5a13...9b17745. Read the comment docs.

Copy link
Member

@dblythy dblythy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @mtrezza. I'm not overly familiar with the source code of custom GH Actions so someone with specific expertise might need to look over this.

Thanks for your great work!!

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gret job. LGTM!

@mtrezza mtrezza merged commit 4a0b4eb into parse-community:master Aug 26, 2021
@mtrezza mtrezza deleted the add-issue-bot branch August 27, 2021 15:07
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add issue bot to assist contributors
5 participants