Skip to content

[WIP] Reduce schema calls on object creation #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 19, 2021

New Pull Request Checklist

Issue Description

In a single server instance environment there shouldn't be a query to the _SCHEMA with the new SchemaCache on object creation.

Fix the flaky test

Schema Performance test schema update class
Error: Could not add field fooOne

Related issue: FILL_THIS_OUT

Approach

I tried to do this the first time but couldn't get it right.

  • Directly update SchemaCache instead of querying.
  • Create new fields in series

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@ghost
Copy link

ghost commented Mar 19, 2021

Danger run resulted in 1 warning; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #7283 (e199ee4) into master (51e0800) will decrease coverage by 9.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7283      +/-   ##
==========================================
- Coverage   93.93%   83.99%   -9.94%     
==========================================
  Files         181      181              
  Lines       13209    13222      +13     
==========================================
- Hits        12408    11106    -1302     
- Misses        801     2116    +1315     
Impacted Files Coverage Δ
src/Adapters/Cache/SchemaCache.js 100.00% <100.00%> (ø)
src/Controllers/SchemaController.js 97.02% <100.00%> (-0.34%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.47% <0.00%> (-92.90%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 5.00% <0.00%> (-65.00%) ⬇️
src/batch.js 75.86% <0.00%> (-15.52%) ⬇️
src/ParseServerRESTController.js 82.08% <0.00%> (-14.93%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 89.97% <0.00%> (-3.27%) ⬇️
src/Controllers/UserController.js 95.34% <0.00%> (-2.33%) ⬇️
src/Controllers/FilesController.js 92.00% <0.00%> (-2.00%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e0800...e199ee4. Read the comment docs.

@dplewis dplewis changed the title Reduce schema calls on object creation [WIP] Reduce schema calls on object creation Mar 20, 2021
@dplewis dplewis mentioned this pull request Apr 1, 2021
2 tasks
@mtrezza
Copy link
Member

mtrezza commented Sep 3, 2021

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

@mtrezza mtrezza closed this Mar 27, 2022
@mtrezza mtrezza deleted the schema-reduction branch March 27, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants