-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Changing user's email: keep using old email before verification new one #5147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lNew." This reverts commit bd8c61f.
Thanks for the Pr, can you address the failing tests and add new tests for this behavior please?
|
@flovilmart I'm not sure, I'll try. I don't have a considerable experience in testing. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Codecov Report
@@ Coverage Diff @@
## master #5147 +/- ##
==========================================
- Coverage 93.88% 93.53% -0.35%
==========================================
Files 123 123
Lines 8939 8977 +38
==========================================
+ Hits 8392 8397 +5
- Misses 547 580 +33
Continue to review full report at Codecov.
|
There is a realization of feature that I've described in this issue. The user can change his email and use an old one until he confirm the new email.
To change email, user should send POST request to
/requestEmailChange
with parameteremail
(new). The new email will be putted toemailNew
DB field. When the user confirm it, the new email will be putted toemail
field, andemailNew
will be cleared.Also I'll prepare a PR to Parse-SDK-JS with this method.
If one needs to block manual email changing (that bypass new scheme), the block in
RestWrite.js
should be uncommented: