refactor: Remove warnings in Docker build #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request!
|
|
This PR is ready for review |
mtrezza
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Thanks for the PR. The PR title is rather vague for a changelog entry. If this only removes warnings but has no other effect for the developer, how about something like:
refactor: Remove warnings in Docker build
If there is another more specific title even better.
cbaker6
changed the title
mtrezza
approved these changes
Jan 28, 2023
|
🎉 This change has been released in version 5.1.0-alpha.8 |
|
🎉 This change has been released in version 5.1.0-beta.2 |
|
🎉 This change has been released in version 5.1.0 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
May 5, 2023
* source: (41 commits) chore(release): 5.1.0 [skip ci] chore(release): 5.1.0-beta.2 [skip ci] ci: Skip unnecessary builds (parse-community#2389) refactor: Upgrade various dependencies (parse-community#2388) chore(release): 5.1.0-alpha.10 [skip ci] fix: Data browser dialog "No data to display" may be outside of visible area in Safari browser (parse-community#2387) chore(release): 5.1.0-alpha.9 [skip ci] fix: Screen goes blank when trying to add column of type `Object` or `GeoPoint` (parse-community#2384) refactor: Bump http-cache-semantics from 4.1.0 to 4.1.1 (parse-community#2381) chore(release): 5.1.0-alpha.8 [skip ci] fix: Internal error message on login with missing credential (parse-community#2370) refactor: Remove warnings in Docker build (parse-community#2350) ci: Restyle preview html (parse-community#2377) chore(release): 5.1.0-alpha.7 [skip ci] fix: Dashboard may display blank page when selecting an app after login (parse-community#2375) ci: Add deployment preview to pull requests via Uffizzi integration (parse-community#2364) chore(release): 5.1.0-alpha.6 [skip ci] fix: Navigation to page fails if user re-login is required (parse-community#2369) refactor: Bump ua-parser-js from 0.7.28 to 0.7.33 (parse-community#2372) chore(release): 5.1.0-alpha.5 [skip ci] ... # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
The Dockerfile currently doesn't conform to the docker best practices or alpine recommendations. This results in a larger than necessary compressed/decompressed image.
I've made similar fixes on the server: parse-community/parse-server#8359
Closes: #2351
Approach
Follow the best practices linked above to properly build the image in stages. This PR has no breaking changes.
For example, when installing packages, alpine docs and docker docs(uses
gitin example code like parse-server) state to use--no-cache.Lastly, the current image uses
--productionwhere it should use--omit=devresulting in additional warnings being thrown in the docker build. This is discussed on stackoverflow.TODOs before merging