feat: improve distinction between deletion confirmation dialogs #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
sadakchap
force-pushed
the
updateConfirmationText
branch
from
b43043f to
ef04868
Compare
4 tasks
|
@sadakchap When this is ready for review, kindly request a review from |
mtrezza
changed the title
|
I think this pr ready for a review. |
4 tasks
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 15, 2022
# [5.0.0-alpha.5](5.0.0-alpha.4...5.0.0-alpha.5) (2022-10-15) ### Features * improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff))
|
🎉 This change has been released in version 5.0.0-alpha.5 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 17, 2022
# [5.0.0-beta.1](4.2.0...5.0.0-beta.1) (2022-10-17) ### Bug Fixes * increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b)) * minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b)) * raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98)) * using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957)) ### Features * improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff)) * keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf)) * remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76)) ### BREAKING CHANGES * This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
|
🎉 This change has been released in version 5.0.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 1, 2022
# [5.0.0](4.2.0...5.0.0) (2022-11-01) ### Bug Fixes * increase required Node engine version to `>=14.20.1`; this is a breaking change, but will be published as a patch version because the change should have been done with the release of `5.0.0-alpha.1` which has just been released ([#2281](#2281)) ([50de52b](50de52b)) * minor UI layout issues ([#2270](#2270)) ([51d083b](51d083b)) * raw value of read-only date field in data browser cannot be copied ([#2326](#2326)) ([4af7b98](4af7b98)) * using browser navigation backward / forward button clears data browser ([#2317](#2317)) ([7d9b957](7d9b957)) ### Features * improve distinction between deletion confirmation dialogs ([#2319](#2319)) ([23c12ff](23c12ff)) * keep entered filter value when changing filter operator ([#2313](#2313)) ([d6d38bf](d6d38bf)) * remove Node 12 support ([#2277](#2277)) ([18b0e76](18b0e76)) ### BREAKING CHANGES * This version removes support for Node 12; the new minimum required Node version is 14. ([18b0e76](18b0e76))
|
🎉 This change has been released in version 5.0.0 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Dec 25, 2022
* release: (41 commits) chore(release): 5.0.0 [skip ci] ci: release commit chore(release): 5.0.0-beta.1 [skip ci] chore(release): 5.0.0-alpha.7 [skip ci] fix: using browser navigation backward / forward button clears data browser (parse-community#2317) docs: update changelog chore(release): 5.0.0-alpha.6 [skip ci] fix: raw value of read-only date field in data browser cannot be copied (parse-community#2326) chore(release): 5.0.0-alpha.5 [skip ci] feat: improve distinction between deletion confirmation dialogs (parse-community#2319) refactor: upgrade otpauth from 8.0.2 to 8.0.3 (parse-community#2322) refactor: upgrade graphiql from 2.0.7 to 2.0.8 (parse-community#2321) chore(release): 5.0.0-alpha.4 [skip ci] feat: keep entered filter value when changing filter operator (parse-community#2313) refactor: upgrade typescript from 4.8.2 to 4.8.3 (parse-community#2308) refactor: bump json-schema and jsprim (parse-community#2303) refactor: upgrade linting dependencies (parse-community#1946) refactor: upgrade semantic-release dependency (parse-community#2301) refactor: upgrade React Router to v6 (parse-community#1954) refactor: upgrade styling dependencies (parse-community#2300) ... # Conflicts: # package-lock.json
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
UX issue. The confirmation dialog to delete selected rows, to delete all rows and to delete the whole class require to enter the class name. All 3 dialogs look similar. The issue is that the dialogs may be mistaken for each other. Also the buttons in the menu to perform these actions are next to each other.
Related issue: #2239
Approach
Updated RowDeleteDialog component, to show different confirmation text based on row selection(props.selection).
selection length >= 10 --> confirmationText = "delete selected"
selected all --> confirmationText = "delete all"
Note: for deleting whole class there is different dialog component(No changes there).
TODOs before merging