⚡ adds ability to run the dashboard from any mount point #217
Conversation
flovilmart
commented
Apr 1, 2016
flovilmart
commented
- fixes allowInsecureHTTP
- fixes allowInsecureHTTP
| @@ -83,7 +83,28 @@ module.exports = function(config) { | |||
|
|
|||
| // For every other request, go to index.html. Let client-side handle the rest. | |||
| app.get('/*', function(req, res) { | |||
| res.sendFile(__dirname + '/index.html'); | |||
| let url = req.url; | |||
There was a problem hiding this comment.
infer the mount path
|
By analyzing the blame information on this pull request, we identified @drew-gross, @flovilmart and @gimdongwoo to be potential reviewers. |
|
Appreciate you looking into this! Good stuff, definitely less intrusive. I like how you inferred the mount path. A few issues that you might want to test:
|
|
You're free to test! |
|
Turns out the images in the push page don't work. Otherwise this looks sweet though. |
|
Yep, also the internal API, need to inject dashboardURL into the config.apps to minimize the footprint on the lib |
|
How would you feel about just injecting the config into the page directly? Then an extra fetch would not be necessary. Also, if you are moving the index.html into the source, can you also delete the actual index.html file? |
|
Yeah I was thinking about that too. also the scss loader is getting crazy with the relative image URL paths.... |
|
Ah, that is unfortuanate :( |
|
no I'm getting through it! |
|
Just noticed the favicon is missing too. Obviously that is lower-pri :p |
|
@flovilmart updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Just remains the internal API calls in lib/ParseApp.js |
|
@flovilmart updated the pull request. |
flovilmart
force-pushed
the
adds-base-head
branch
from
7c75d16 to
678940e
Compare
flovilmart
force-pushed
the
adds-base-head
branch
from
678940e to
eb09de5
Compare
|
@drew-gross that should be it! |
|
@flovilmart updated the pull request. |
| // abortable flag used to pass xhr reference so user can abort accordingly | ||
| export function request(method, url, body, abortable = false, withCredentials = true, useRequestedWith = true) { | ||
| if (!url.startsWith('http://') |
There was a problem hiding this comment.
open to suggestions about that, that's the less invasive I've found
There was a problem hiding this comment.
Yeah this is fine. The only things that aren't going to go through the Parse sdk are the config loading, and potentially this app creation stuff that is being discussed.
|
@flovilmart great job with this PR! With this, will we now be allowed to deploy the dashboard to Heroku? If so, how could I go about that? Do I need to set any specific environment/config variables? |
|
🎉 This change has been released in version 4.0.0-beta.1 |
|
🎉 This change has been released in version 4.0.0 |
