Skip to content

refactor: upgrade CI deps, bump Node.js version to 14 #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

damianstasik
Copy link
Contributor

New Pull Request Checklist

Issue Description

This PR upgrades CI dependencies, but also bumps the minimum version of Node to 14 since semantic-release minimum Node version is 14.17.0. It would be also good for the dashboard to require Node 14 as Node 12 will reach end-of-life is on 2022-04-30.

Related issue: #1902

Approach

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik mentioned this pull request Dec 5, 2021
56 tasks
@damianstasik
Copy link
Contributor Author

@mtrezza semantic-release requires Node v14, should we ignore the update or bump our Node version to match it?

@mtrezza
Copy link
Member

mtrezza commented Dec 10, 2021

... bumps the minimum version of Node to 14 since semantic-release minimum Node version is 14.17.0.

A dev dependency min node version should not determine the product's min node version. Dev dependencies are not used in the final product, unless maybe dev dependencies for testing. It's possible that the "Node engine check" also considers dev dependencies, which it should not. If there is no good reason to upgrade semantic release to a version that requires Node 14, we don't have to do it. In April next year we'll drop Node 12 support anyway, then we can also upgrade semantic release.

It would be also good for the dashboard to require Node 14 as Node 12 will reach end-of-life is on 2022-04-30

The dashboard repo does not have a compatibility table, but if you look at the one for Parse Server, you can see that we support a Node version until the end of its LTS date. I opened #1956 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants